Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: concise poetry run #940

Closed
dimaqq opened this issue Mar 7, 2019 · 4 comments
Closed

Proposal: concise poetry run #940

dimaqq opened this issue Mar 7, 2019 · 4 comments

Comments

@dimaqq
Copy link
Contributor

dimaqq commented Mar 7, 2019

My colleague is working to verse our codebase, and I get to review the change.
I see that most poetry run invocation are:

  • poetry run python
  • poetry run pip
  • poetry run pytest

I with that python, pip, pytest were first-class citizens.

That is:
poetry run python becomes poetry python
poetry run pip becomes poetry pip (arguably poetry own functionality should be used instead)
And then:
poetry run pytest becomes poetry pytest
poetry run <entrypoint> becomes poetry <entrypoint>

The last part is a little more involved, but the logic is the same, check if argument is an "executable" (python, script, package entry point), and if so, run it.

@ojii
Copy link
Contributor

ojii commented Mar 7, 2019

While originally #241 was not about this, it has now turned into a discussion about adding something like this, so this is probably a duplicate.

Note that you can also poetry shell to activate the virtualenv and not having to type poetry run ... all the time.

@floer32 floer32 mentioned this issue Mar 12, 2019
2 tasks
@floer32
Copy link

floer32 commented Mar 12, 2019

I like this intent and I think it could do a lot to address #241 and an alternative to #591.

Update: a bunch more details on #591 now, this issue could be critical to having clean support for general dev task execution.

@sdispater
Copy link
Member

This would confusion, or even collision in some cases, so this is not something I am willing to add to Poetry

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants