-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope merging #37
Comments
Two important observations need to be made. First, I ran the same code, and observed some other properties. This points to what could be considered a bug, but not the one you are thinking of. (I trimmed some extraneous blank lines.)
Second, the document is not valid TOML, because the contents of
The fact that |
Ok, I don't have an issue with this viewpoint I just can't find the TOML specs explicitly stating that implicit and explicit tables cannot be mixed. Just checked the ABNF and it doesn't prohibit it (but then the ABNF permits the same table to be defined multiple times and I know that's not permitted). Just checked qTOML, they allow this. |
It was a matter of interpretation that wasn't explicitly specified in the standard, though the principle that you cannot define any table more than once is explicitly stated in v0.5.0. The introduction of dotted keys opened up a can of worms; there is still interpretation to be applied, and standards language to be updated. Based on the strictest standards possible, the TOML in your example is invalid because the table I've brought this up for debate under the TOML standard issue where these interpretations are being made. By the way, the ABNF would consider the example well-formed, but it does nothing to identify whether it's valid. |
Ok, so I got caught up on the toml discussion, and I agree this isn't explicitly understood yet. At least until this is better defined I feel the correct answer to this is to leave it up to the developer using tomlkit to decide which interpretation to allow in their case. |
The following is valid however tomlkit isn't able to properly handle the dual scopes:
The text was updated successfully, but these errors were encountered: