Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobSet.finished_job incriments self.done too late #10

Closed
mcepl opened this issue Nov 30, 2013 · 1 comment
Closed

JobSet.finished_job incriments self.done too late #10

mcepl opened this issue Nov 30, 2013 · 1 comment

Comments

@mcepl
Copy link
Contributor

mcepl commented Nov 30, 2013

While no one was looking, Lex Luthor took JobSet's ability to be 100% done in the eyes of observing functions. He took JobSet's ability to be one hundred percent done in the eyes of observing functions. That's as many as ten ten percents. And that's terrible.

Read: Because self.done is incremented after self.handle._inform_observers() an observing function will never see JobSet.get_percent_done() == 100.

https://gist.github.com/7761137
@mcepl
Copy link
Contributor Author

mcepl commented Nov 30, 2013

Fixed in 687c1cb597ed

@mcepl mcepl closed this as completed Nov 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcepl