Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoimport does not correctly use index #736

Closed
lieryan opened this issue Dec 17, 2023 · 1 comment · Fixed by #739
Closed

autoimport does not correctly use index #736

lieryan opened this issue Dec 17, 2023 · 1 comment · Fixed by #739

Comments

@lieryan
Copy link
Member

lieryan commented Dec 17, 2023

Describe the bug

Related conversation:

@MrBago made an IPython notebook testing the performance of an unrelated query. This brings up an unrelated performance issue with the search_by_module_like and likely the other like queries as well.

A prefix search using an index should not have been that slow. Indeed, it doesn't seem to be correctly using the index as EXPLAIN QUERY PLAN shows that it is doing a full table scan on the LIKE query so the index doesn't seem to be defined correctly, I think this is because of a case sensitivity issue on the index.

To Reproduce
Steps to reproduce the behavior:

In [78]: %time _ = list(autoimport._execute(m.Name.search_module_like.select_star(), ["abc"]))
@lieryan lieryan added the bug Unexpected or incorrect user-visible behavior label Dec 17, 2023
@lieryan lieryan added enhancement performance and removed bug Unexpected or incorrect user-visible behavior labels Dec 21, 2023
@tkrabel-db
Copy link

@lieryan are there any updates on this issue? Do you have an ETA when you want to do this? I have capacity to work on this, so I am happy to help!

@lieryan lieryan added this to the 1.12.0 milestone Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants