Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tests for try_orelse_with_no_variables_to_save.py and try_orelse_with_no_variables_to_save_and_no_args.py #62

Closed
KevinHock opened this issue Aug 29, 2017 · 6 comments

Comments

@KevinHock
Copy link
Collaborator

KevinHock commented Aug 29, 2017

In this commit 23e6412 you can see where this would affect the program. (Search for "# raise")

The test would be just like test_orelse in cfg_test.py.

@KevinHock KevinHock changed the title Create tests for try_orelse_with_no_variables_to_save and try_orelse_with_no_variables_to_save_and_no_args Create tests for try_orelse_with_no_variables_to_save.py and try_orelse_with_no_variables_to_save_and_no_args.py Mar 19, 2018
@KevinHock
Copy link
Collaborator Author

KevinHock commented Mar 19, 2018

So the test python files are there, and the # raise comments I made are still the right places, some names have been changed but the 2 spots are now

first_node = restore_node
and
first_node = entry_node
I think.

@KevinHock
Copy link
Collaborator Author

The docstring in process_function should be very helpful.

@venkatavamsy
Copy link

Looking into this. :)

@KevinHock
Copy link
Collaborator Author

Hi @omergunal

7a28429

should be enough to get you going 👍

@omergunal
Copy link
Contributor

this was very helpful :)

@KevinHock
Copy link
Collaborator Author

🎈🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants