You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#238's squash commit (2e1c50a), for a reason that I haven't figured out yet, had its description parsed as one large paragraph instead of being split.
Additional context
2020-05-15T15:43:12.0024885Z debug: parse_commit_message('feat(history): create emoji parser (#238)
2020-05-15T15:43:12.0025051Z debug:
2020-05-15T15:43:12.0025265Z debug: Add a commit parser which uses emojis from https://gitmoji.carloscuesta.me/
2020-05-15T15:43:12.0025441Z debug: to determine the type of change.
2020-05-15T15:43:12.0025570Z debug:
2020-05-15T15:43:12.0025702Z debug: * fix: add emojis to default changelog_sections
2020-05-15T15:43:12.0025841Z debug:
2020-05-15T15:43:12.0025969Z debug: * fix: include all parsed types in changelog
2020-05-15T15:43:12.0026085Z debug:
2020-05-15T15:43:12.0026223Z debug: This allows emojis to appear in the changelog, as well as configuring
2020-05-15T15:43:12.0026384Z debug: other types to appear with the Angular parser (I remember someone asking
2020-05-15T15:43:12.0026539Z debug: for that feature a while ago). All filtering is now done in the
2020-05-15T15:43:12.0026678Z debug: markdown_changelog function.
2020-05-15T15:43:12.0026805Z debug:
2020-05-15T15:43:12.0026938Z debug: * refactor(history): get breaking changes in parser
2020-05-15T15:43:12.0027075Z debug:
2020-05-15T15:43:12.0027212Z debug: Move the task of detecting breaking change descriptions into the commit
2020-05-15T15:43:12.0027367Z debug: parser function, instead of during changelog generation.
2020-05-15T15:43:12.0027485Z debug:
2020-05-15T15:43:12.0027622Z debug: This has allowed the emoji parser to also return the regular descriptions as
2020-05-15T15:43:12.0027786Z debug: breaking change descriptions for commits with :boom:.
2020-05-15T15:43:12.0027917Z debug:
2020-05-15T15:43:12.0028061Z debug: BREAKING CHANGE: Custom commit parser functions are now required to pass
2020-05-15T15:43:12.0028217Z debug: a fifth argument to `ParsedCommit`, which is a list of breaking change
2020-05-15T15:43:12.0028356Z debug: descriptions.
2020-05-15T15:43:12.0028476Z debug:
2020-05-15T15:43:12.0028786Z debug: * docs: add documentation for emoji parser')
2020-05-15T15:43:12.0030497Z debug: parse_commit_message -> ParsedCommit(bump=2, type='feature', scope='history', descriptions=['create emoji parser (#238)', 'Add a commit parser which uses emojis from https://gitmoji.carloscuesta.me/\r to determine the type of change.\r \r * fix: add emojis to default changelog_sections\r \r * fix: include all parsed types in changelog\r \r This allows emojis to appear in the changelog, as well as configuring\r other types to appear with the Angular parser (I remember someone asking\r for that feature a while ago). All filtering is now done in the\r markdown_changelog function.\r \r * refactor(history): get breaking changes in parser\r \r Move the task of detecting breaking change descriptions into the commit\r parser function, instead of during changelog generation.\r \r This has allowed the emoji parser to also return the regular descriptions as\r breaking change descriptions for commits with :boom:.\r \r BREAKING CHANGE: Custom commit parser functions are now required to pass\r a fifth argument to `ParsedCommit`, which is a list of breaking change\r descriptions.\r \r * docs: add documentation for emoji parser'], breaking_descriptions=[])
The text was updated successfully, but these errors were encountered:
Aaaah, because I created the commit on a Windows machine, it has \r\n line separators, so text.split('\n\n') didn't work since there was a \r in the middle. I think the best solution to this is to simply remove all \rs before processing.
The problem
#238's squash commit (2e1c50a), for a reason that I haven't figured out yet, had its description parsed as one large paragraph instead of being split.
Additional context
The text was updated successfully, but these errors were encountered: