Asyncio

[Bibo-Joshi]

Supersedes #2402. Closes #2288 when ready - which is not in the forseable future :D

• ext-tests are deleted for now so that we can first concentrate on getting telegram to work
• any changes to v14 should be merged into this ASAP

TODO

Let's use this as place to write everything down that comes to mind while working on this - will be a lot

• move PtbRequestBase and HttpxRequest to a tg.request module/package. Maybe rename to RequestBase and HTTPXRequest
• Improve handling of files in request - probably move that logic into a standalone method or even into Bot?
• Update error code handling in request, use the enum from the std-lib
• Check if we get coroutine was never awaited somewhere in the tests and also check if we can make those warnings fail the tests
• check back with noam on whether the timeout parameter should be used for write_timeout as well in in BaseRequest
• Check back with Noam about httpx connection pool limits: IISC on pool_timeout we want to create a new connection instead of dropping the request?!
• Think about how we handle non-async callbacks for handlers and jobs. We might want to make sure that they run in a background thread - which is the default behavior of APscheduler

• Think about what to do with exceptions in the long running tasks of updater. Currently we put them in the update_queue, which isn't really nice
• persistence
• think about a replacement for exception_event
• a lot of tests
  • For JobQueue test that weekdays are working as expected to avoid regression when we update APS - see here and here
• check for added # TODO comments
• update examples. for chatmemberbot.py we can also include the changes proposed here

Things that don't need to be done in this PR

If they are not, create issues for them!

• set socketops
• switch to a different library for webhooks - maybe starlette (backend of fastAPI)?
• Add transaction support to BaspePersistence, i.e. abstract methods start/end_transaction so that we can do

1. tell persistence that we're going to start transaction
2. hand over data
3. tell persistence that I'm finished

Review

Thinks to look out for in a review

• double check if we need to update docs regarding accepted types
• Check for unwanted changes (also in tests!) - these are likely to be there because merging v14 was a mess
  • Some test_slots_behavior tests went missing for some reason. check the diff and re-add them
• Add .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings
• Also manually check whether thumbs are properly handled everywhere(!) where you can pass a thumb
• take all the examples up for a test run
• manually test webhook setups - this PR changes if the webserver listens to https://… or http://…
• manually test how kill pid works when using App.run_* & starting the script as a background task

???

I wrote this down while working on a signal-handler based exit. not sure, if still relevant

• On windows, quick-exit by task.cancel() leads to the issue discribed in https://bugs.python.org/issue39232. Can be resolved by using loop.run_until_complete() instead of asycnio.run(). think about if we want to address this somehow (documentation/helper function/adapting the internals or mechanichs or updater)
• asyncio.run in combination with webhooks leads to asyncio.run() causes RuntimeError because of loop.close() tornadoweb/tornado#3092 - check if we can do something smart about that

[github-actions]

Hey! Looks like you edited README.rst or README_RAW.rst. I'm just a friendly reminder to apply relevant changes to both of those files :)

[github-actions]

Hey there. Relax, I am just a little warning for the maintainers to release directly after merging your PR, otherwise we have broken examples and people might get confused :)

[github-actions]

Hey! Looks like you edited the (dev) requirements or the pre-commit hooks. I'm just a friendly reminder to keep the pre-commit hook versions in sync with the dev requirements and the additional dependencies for the hooks in sync with the requirements :)

[Bibo-Joshi]

I scrolled through all files and tests and made a number of samller fine tunings. in the tests, I didn't notice any obvious false deletions. I guess we're down to

1. checking thumbs support
2. checking webhook support
3. checking how kill pid wirks

pool wants to do 1 & 2 tomorrow, I'll have a look at 3 in a minute.
after that we can probably continue to search for doc improvements & small tweaks indefinitely - or merge 🥳

• test_official is failing for obvious reasons
• codacy complains about a "hard coded token" in the payment example and I haven't figured out how to mute that - IMO we can just ignore.

[harshil21]

uploading files rework review.

Btw codecov shows that quite a few lines in Application and ConversationHandler are not covered in tests?