Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Py3.8+ features: missing_ok Parameter #3730

Closed
Tracked by #3728
Bibo-Joshi opened this issue Jun 2, 2023 · 1 comment
Closed
Tracked by #3728

Adopt Py3.8+ features: missing_ok Parameter #3730

Bibo-Joshi opened this issue Jun 2, 2023 · 1 comment
Labels
good first issue tests

Comments

@Bibo-Joshi
Copy link
Member

Python 3.8 adds a missing_ok argument to the method Path.unlink. This method is used in our test suite at a few places. Setting missing_ok=True may help avoiding unexpected errors in the test runs.

A PR in this direction is very welcome. As long as #3728 is open, it should be based on the drop-py-37 branch. If you would like to send a PR, please be sure to read our contribution guide and leave a short comment so that we can assign you.
@Bibo-Joshi Bibo-Joshi mentioned this issue Jun 2, 2023
Merged
17 tasks
@Trifase Trifase mentioned this issue Jun 3, 2023
Merged
@Bibo-Joshi
Copy link
Member Author

Closed by #3742

@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Bibo-Joshi