Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt Py3.8+ features: Drop workaround in PicklePersistence #3732

Closed
Tracked by #3728
Bibo-Joshi opened this issue Jun 2, 2023 · 0 comments · Fixed by #3740
Closed
Tracked by #3728

Adopt Py3.8+ features: Drop workaround in PicklePersistence #3732

Bibo-Joshi opened this issue Jun 2, 2023 · 0 comments · Fixed by #3740

Comments

@Bibo-Joshi
Copy link
Member

With dropping python 3.7 it's possible to remove a py-37-specific workorund in the PicklePersistence implementation. More details can be found here. We should revisit that implementation and remove all python-3.7 specific code. The corresponding test cases also needs to be adapted to drop any python 3.7 related clauses.

A PR in this direction is very welcome. As long as #3728 is open, it should be based on the drop-py-37 branch. If you would like to send a PR, please be sure to read our contribution guide and leave a short comment so that we can assign you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants