Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add Update.effective_sender #4085

Closed
Poolitzer opened this issue Jan 29, 2024 · 6 comments · Fixed by #4168
Closed

[FEATURE] Add Update.effective_sender #4085

Poolitzer opened this issue Jan 29, 2024 · 6 comments · Fixed by #4168

Comments

@Poolitzer
Copy link
Member

We have Update.effective_user for the sender of the message. This attribute however misses out on the anonymous sender info provided in Message.sender_chat, MessageReactionUpdated.action_chat and Poll.voter_chat.

I would propose adding a new shortcut to the Update class, effective_sender. It either returns the sender chats above or effective_user, if they are not set.

@nemo-1999
Copy link

Hi, I would like to work on this

@Poolitzer
Copy link
Member Author

Alright, have fun!

@Bibo-Joshi
Copy link
Member

@Poolitzer Please keep in mind that this is dependent on the ongoing API 7.0 pr

@Poolitzer
Copy link
Member Author

Oh right, you should base your branch on this. So either wait until it is merged with master and then do the PR or branch it on the api branch and PR towards it if you are eager to do it now.

@nemo-1999
Copy link

I can wait. Until then I can take a look at the code base and understand the req better

@harshil21
Copy link
Member

I can wait. Until then I can take a look at the code base and understand the req better

@nemo-1999 you may start working on this now since it's already merged to master

@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants