Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autodetect :for: false positive #195

Open
belm0 opened this issue Sep 9, 2020 · 2 comments
Open

autodetect :for: false positive #195

belm0 opened this issue Sep 9, 2020 · 2 comments

Comments

@belm0
Copy link
Member

belm0 commented Sep 9, 2020

autodetect is confused by the async_friendly_context_manager in trio_util and incorrectly detects :for: on method multi_error_defer_to() decorated by it.

https://github.com/groove-x/trio-util/blob/944bf42b08b31f549179325eec443851dbd849a5/src/trio_util/_exceptions.py

@DevilXD
Copy link
Contributor

DevilXD commented Mar 25, 2021

You're missing a @ character on lines 18 and 23, without that, wraps(func) alone won't do anything.

@belm0
Copy link
Member Author

belm0 commented Mar 25, 2021

@DevilXD thank you-- fixed

the false positive :for: is persisting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants