Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support ExceptionGroup wrapping in trio 0.25.0+ #146

Closed
oremanj opened this issue Apr 17, 2024 · 0 comments · Fixed by #147
Closed

Properly support ExceptionGroup wrapping in trio 0.25.0+ #146

oremanj opened this issue Apr 17, 2024 · 0 comments · Fixed by #147

Comments

@oremanj
Copy link
Member

oremanj commented Apr 17, 2024

For now, we're punting by pinning trio to <0.25.0 for our CI. Instead, we should update our testsuite to use the new RaisesGroup and other testing tools to properly handle the ExceptionGroup wrapping.

I don't think there are any hazards to trio-asyncio users, beyond the fact that open_loop() now adds ExceptionGroup layers, so this should be just a testsuite change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant