Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change in TypeVarType causes an error during typecheck #84

Closed
fjarri opened this issue Jun 22, 2023 · 0 comments · Fixed by #83
Closed

Breaking change in TypeVarType causes an error during typecheck #84

fjarri opened this issue Jun 22, 2023 · 0 comments · Fixed by #83

Comments

@fjarri
Copy link

fjarri commented Jun 22, 2023

Mypy 1.4 includes PR python/mypy#14872 that added a positional deault parameter to the mypy.types.TypeVarType constructor. plugin.py::takes_callable_and_args_callback() invokes it without that argument, causing mypy to crash.

This seems to be fixed by passing AnyType(TypeOfAny.from_omitted_generics) as an additional argument, but this will make trio-typing incompatible with mypy<1.4. Thoughts on how to proceed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for mypy 1.4 changes VincentVanlaer/trio-typing
1 participant
@fjarri