Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Event directly with wait_task_rescheduled rather than ParkingLot #1948

Merged
merged 4 commits into from Apr 7, 2021

Conversation

belm0
Copy link
Member

@belm0 belm0 commented Apr 5, 2021

raised in #1944

@belm0 belm0 requested a review from njsmith April 5, 2021 14:01
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #1948 (0976de4) into master (52a210f) will decrease coverage by 0.46%.
The diff coverage is 100.00%.

❗ Current head 0976de4 differs from pull request most recent head d7a84ab. Consider uploading reports for the commit d7a84ab to get more accurate results

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
- Coverage   99.58%   99.12%   -0.47%     
==========================================
  Files         114      114              
  Lines       14617    14627      +10     
  Branches     1116     1119       +3     
==========================================
- Hits        14557    14499      -58     
- Misses         43       96      +53     
- Partials       17       32      +15     
Impacted Files Coverage Δ
trio/_sync.py 100.00% <100.00%> (ø)
trio/_subprocess_platform/waitid.py 35.89% <0.00%> (-33.34%) ⬇️
trio/_core/_wakeup_socketpair.py 84.21% <0.00%> (-15.79%) ⬇️
trio/socket.py 92.30% <0.00%> (-7.70%) ⬇️
trio/_core/_multierror.py 95.50% <0.00%> (-4.50%) ⬇️
trio/_subprocess.py 93.23% <0.00%> (-4.35%) ⬇️
trio/_util.py 96.61% <0.00%> (-3.39%) ⬇️
trio/_core/tests/tutil.py 96.61% <0.00%> (-3.39%) ⬇️
trio/_unix_pipes.py 97.72% <0.00%> (-2.28%) ⬇️
trio/_core/tests/test_ki.py 99.13% <0.00%> (-0.87%) ⬇️
... and 7 more

trio/_sync.py Outdated Show resolved Hide resolved
trio/_sync.py Show resolved Hide resolved
belm0 and others added 2 commits April 6, 2021 11:35
@belm0
Copy link
Member Author

belm0 commented Apr 6, 2021

ready to go (unless it needs a newsfragment)

suggest "squash and merge" option for merge

@njsmith njsmith merged commit 6b313de into python-trio:master Apr 7, 2021
@belm0 belm0 deleted the lightweight_event branch April 8, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants