drop python 3.7 support, drop pypy3.7-3.8, add pypy3.10 (except on windows) #2668

jakkdl · 2023-06-23T12:08:19Z

With 3.7 EOL coming up in 4 days, I thought it time to start writing a PR for dropping it so #2655 can move ahead afterwards.

Only thing I stumbled on so far (until CI tells me otherwise) was trio/_util:coroutine_or_error - which seems to be more than an easy search/replace fix.

codecov · 2023-06-23T12:12:13Z

Codecov Report

Merging #2668 (08c972b) into master (6f187fb) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2668      +/-   ##
==========================================
+ Coverage   98.84%   98.88%   +0.04%     
==========================================
  Files         113      113              
  Lines       16508    16482      -26     
  Branches     3010     3000      -10     
==========================================
- Hits        16317    16299      -18     
+ Misses        134      126       -8     
  Partials       57       57

Impacted Files	Coverage Δ
trio/_core/_tests/test_multierror.py	`100.00% <ø> (ø)`
trio/_path.py	`100.00% <ø> (ø)`
trio/_socket.py	`100.00% <ø> (ø)`
trio/_tests/test_ssl.py	`99.85% <ø> (-0.01%)`	⬇️
trio/_unix_pipes.py	`100.00% <ø> (ø)`
trio/_util.py	`100.00% <ø> (ø)`
trio/socket.py	`100.00% <ø> (ø)`
trio/_channel.py	`100.00% <100.00%> (ø)`
trio/_core/_run.py	`99.24% <100.00%> (ø)`
trio/_core/_tests/tutil.py	`98.03% <100.00%> (+11.88%)`	⬆️
... and 1 more

trio/_core/_tests/tutil.py

trio/_util.py

A5rocks · 2023-06-26T02:45:23Z

Hi, if I actually am able to release stuff I want to do a patch release with current changes (and without this PR), then soon after a minor release with this PR. This way there's a published version of trio that supports 3.7-3.12 (beta, at least). Sorry it took me a while to figure that out, but that means this PR will have to wait a bit!

jakkdl · 2023-06-26T11:12:14Z

Hi, if I actually am able to release stuff I want to do a patch release with current changes (and without this PR), then soon after a minor release with this PR. This way there's a published version of trio that supports 3.7-3.12 (beta, at least). Sorry it took me a while to figure that out, but that means this PR will have to wait a bit!

That sounds like a good approach, no worries at all!

A5rocks · 2023-06-26T14:02:13Z

We can probably ~~replace~~ supplement (I just realied @final does no runtime checking) _util.Final with a @final from typing?

https://github.com/python-trio/trio/blob/master/trio/_util.py#L268-L290

jakkdl · 2023-06-26T15:35:39Z

I have no clue what the notes-to-self directory is, but ran pyupgrade (and black) on that as well.

jakkdl · 2023-06-26T16:04:56Z

We can probably ~~replace~~ supplement (I just realied @final does no runtime checking) _util.Final with a @final from typing?

https://github.com/python-trio/trio/blob/master/trio/_util.py#L268-L290

Hmm, I'm failing to find a way to get both runtime and static checking to work with a single decorator/metaclass (it seems mypy checks for @final by identity against typing.final? Even reassigning typing.final to a different variable and using that variable as a decorator doesn't work). So this would entail doubling up and having both @final and metaclass=Final on the classes.

…rements.txt

jakkdl · 2023-07-03T11:49:54Z

Dropping windows pypy3.10, leaving that for another PR.

jakkdl · 2023-07-05T16:03:07Z

@A5rocks wanna review/merge?

A5rocks

Looks mostly good. Please edit pyproject.toml to make black use py38 as a minimum version. I don't think it changes anything though.

Sorry about the delay in reviewing! ... I swear I had another thing in mind to ask you to change but whatever, we'll catch it eventually and it won't break anything.

A5rocks · 2023-07-06T04:55:34Z

.github/workflows/ci.yml

@@ -66,7 +66,7 @@ jobs:
          # support this for PyPy presently so we get no help there.


note to self: test if this is supported yet. It probably works!

.github/workflows/ci.yml

A5rocks · 2023-07-06T05:01:16Z

.github/workflows/ci.yml

@@ -143,7 +143,7 @@ jobs:
    strategy:
      fail-fast: false
      matrix:
-        python: ['3.7', '3.8', '3.9', '3.10', 'pypy-3.8-nightly', 'pypy-3.9-nightly']
+        python: ['3.8', '3.9', '3.10', 'pypy-3.9-nightly', 'pypy-3.10-nightly']


Mind adding at least pypy 3.10 here?

In addition to pypy-3.10-nightly? Ubuntu tests both pypy-3.10 and pypy-3.10-nightly, windows & mac has always only tested pypy-nightlies (no clue why they do that instead of the stable releases though)

README.rst

docs/source/reference-core.rst

test-requirements.in

test-requirements.txt

trio/_core/_tests/tutil.py

A5rocks

Just remembered the one more thing: can you make a news fragment?

Fuyukai · 2023-07-11T12:38:08Z

newsfragments/2668.headline.rst

@@ -0,0 +1 @@
+Drop support for python3.7, pypy3.7 and pypy3.8.


should be Python 3.7 and PyPy 3.7/3.8 or similar.

A5rocks

This seems fine now.

Except for capitalization in the newsfragment, I suppose.

A5rocks

Sorry, I've been thinking about it and IMO this isn't really a "headline" feature; in the past this was a .removal.

That plus the capitalization thing are my only concerns, after which feel free to merge!

… newsfragments/README.rst

jakkdl · 2023-07-17T07:36:13Z

This seems fine now.

Except for capitalization in the newsfragment, I suppose.

Oh, I missed that capitalization was what Fuyukai actually was requesting be modified. Thanks for clarifying :)

jakkdl · 2023-07-17T07:41:20Z

Sorry, I've been thinking about it and IMO this isn't really a "headline" feature; in the past this was a .removal.

That plus the capitalization thing are my only concerns, after which feel free to merge!

removal wasn't listed in newsfragments/README.rst - added it + description it should be used when dropping versions. Feel free to modify that if you want to

jakkdl requested a review from A5rocks June 23, 2023 12:10

jakkdl commented Jun 24, 2023

View reviewed changes

trio/_core/_tests/tutil.py Outdated Show resolved Hide resolved

jakkdl commented Jun 25, 2023

View reviewed changes

trio/_util.py Show resolved Hide resolved

jakkdl mentioned this pull request Jun 25, 2023

@enable_ki_protection breaks inspect.iscoroutinefunction #2670

Open

jakkdl force-pushed the drop_3.7 branch from 06b3cdd to b4fdb17 Compare June 25, 2023 10:24

jakkdl marked this pull request as ready for review June 25, 2023 10:24

jakkdl force-pushed the drop_3.7 branch from c2e8acd to 94bbdba Compare June 26, 2023 15:34

zanieb mentioned this pull request Jun 27, 2023

Drop support for Python 3.7 encode/httpx#2744

Closed

3 tasks

jakkdl mentioned this pull request Jul 1, 2023

Prevent typing_extensions 4.7.0 #2676

Merged

jakkdl force-pushed the drop_3.7 branch from 94bbdba to 678c3c3 Compare July 1, 2023 11:34

jakkdl added 9 commits July 3, 2023 12:19

drop python 3.7 support

fc81dee

remove more code, mark lines with pragma: no cover, update test-requi…

7cf58b2

…rements.txt

stop special-casing IPPROTO_IPV6 entirely

3cacea9

remove disable_threading_excepthook

98379e4

run pyupgrade --py38-plus

7bc0826

also run it on the notes-to-self directory

45e22a8

drop pypy-3.8, add pypy-3.10 and pypy-3.10-nightly to CI

7d5b484

leave pypy-3.10 for a different PR, re-fix tuple->Tuple mypy fail on 3.8

04f1792

revert dropping pypy3.10, bump cryptography

b3366e1

jakkdl force-pushed the drop_3.7 branch from e1f624d to b3366e1 Compare July 3, 2023 10:23

jakkdl added 4 commits July 3, 2023 12:40

fix f401 CI

951b996

add pypy3.10 on windows, test limiting cryptography to <41

087998c

update req.txt to actually limit cryptography <41

29f44a5

drop pypy3.8, try crypto41 + pypy3.9

4dc2241

drop windows pypy3.10 from CI

e9ac69d

jakkdl changed the title ~~drop python 3.7 support~~ drop python 3.7 support, drop pypy3.7 and pypy3.8, add pypy3.10 (except on windows) Jul 3, 2023

jakkdl changed the title ~~drop python 3.7 support, drop pypy3.7 and pypy3.8, add pypy3.10 (except on windows)~~ drop python 3.7 support, drop pypy3.7-3.8, add pypy3.10 (except on windows) Jul 3, 2023

jakkdl added 2 commits July 3, 2023 13:54

clean up test_requirements.in

19b3aac

update readme clarifying pypy version requirement

050ba35

jakkdl mentioned this pull request Jul 3, 2023

pypy-3.10 support #2678

Closed

Fuyukai approved these changes Jul 4, 2023

View reviewed changes

jakkdl mentioned this pull request Jul 4, 2023

Add static analysis support to _util.Final #2683

Closed

A5rocks requested changes Jul 6, 2023

View reviewed changes

fixes after CI review from A5rocks

8590621

A5rocks requested changes Jul 6, 2023

View reviewed changes

jakkdl added 2 commits July 7, 2023 12:17

revert version requirement on typing-extensions, add newsfragments

44d4ee3

Merge branch 'main' into drop_3.7

0991961

jakkdl requested a review from A5rocks July 7, 2023 10:31

Merge branch 'main' into drop_3.7

63dfc70

Fuyukai reviewed Jul 11, 2023

View reviewed changes

Update 2668.headline.rst

e3771d8

jakkdl mentioned this pull request Jul 16, 2023

typecheck _socket and _core._local #2705

Merged

A5rocks approved these changes Jul 17, 2023

View reviewed changes

jakkdl added 2 commits July 17, 2023 09:34

fix capitalization in newsfragment, headline->removal, add removal to…

a2a4fd2

… newsfragments/README.rst

Merge remote-tracking branch 'origin/master' into drop_3.7

08c972b

jakkdl merged commit bf9fe64 into python-trio:master Jul 17, 2023
28 checks passed

jakkdl deleted the drop_3.7 branch July 17, 2023 07:59

This was referenced Jul 18, 2023

Bump dependencies from commit bf9fe6 #2708

Closed

Bump dependencies from commit bf9fe6 #2709

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop python 3.7 support, drop pypy3.7-3.8, add pypy3.10 (except on windows) #2668

drop python 3.7 support, drop pypy3.7-3.8, add pypy3.10 (except on windows) #2668

jakkdl commented Jun 23, 2023

codecov bot commented Jun 23, 2023 •

edited

A5rocks commented Jun 26, 2023

jakkdl commented Jun 26, 2023

A5rocks commented Jun 26, 2023 •

edited

jakkdl commented Jun 26, 2023

jakkdl commented Jun 26, 2023

jakkdl commented Jul 3, 2023

jakkdl commented Jul 5, 2023

A5rocks left a comment

A5rocks Jul 6, 2023

A5rocks Jul 6, 2023

jakkdl Jul 6, 2023

A5rocks left a comment

Fuyukai Jul 11, 2023

A5rocks left a comment •

edited

A5rocks left a comment

jakkdl commented Jul 17, 2023

jakkdl commented Jul 17, 2023

		@@ -66,7 +66,7 @@ jobs:
		# support this for PyPy presently so we get no help there.

		@@ -0,0 +1 @@
		Drop support for python3.7, pypy3.7 and pypy3.8.

drop python 3.7 support, drop pypy3.7-3.8, add pypy3.10 (except on windows) #2668

drop python 3.7 support, drop pypy3.7-3.8, add pypy3.10 (except on windows) #2668

Conversation

jakkdl commented Jun 23, 2023

codecov bot commented Jun 23, 2023 • edited

Codecov Report

A5rocks commented Jun 26, 2023

jakkdl commented Jun 26, 2023

A5rocks commented Jun 26, 2023 • edited

jakkdl commented Jun 26, 2023

jakkdl commented Jun 26, 2023

jakkdl commented Jul 3, 2023

jakkdl commented Jul 5, 2023

A5rocks left a comment

Choose a reason for hiding this comment

A5rocks Jul 6, 2023

Choose a reason for hiding this comment

A5rocks Jul 6, 2023

Choose a reason for hiding this comment

jakkdl Jul 6, 2023

Choose a reason for hiding this comment

A5rocks left a comment

Choose a reason for hiding this comment

Fuyukai Jul 11, 2023

Choose a reason for hiding this comment

A5rocks left a comment • edited

Choose a reason for hiding this comment

A5rocks left a comment

Choose a reason for hiding this comment

jakkdl commented Jul 17, 2023

jakkdl commented Jul 17, 2023

codecov bot commented Jun 23, 2023 •

edited

A5rocks commented Jun 26, 2023 •

edited

A5rocks left a comment •

edited