Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the google docstring url #2967

Merged
merged 1 commit into from Mar 3, 2024

Conversation

kachida
Copy link
Contributor

@kachida kachida commented Mar 3, 2024

Updated Google Docstring Format link since currently it points to a 404 page.

Fixes #2546

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (48f8293) to head (f5d6c89).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2967   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files         117      117           
  Lines       17634    17634           
  Branches     3172     3172           
=======================================
  Hits        17572    17572           
  Misses         43       43           
  Partials       19       19           

Copy link
Contributor

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jakkdl
Copy link
Member

jakkdl commented Mar 3, 2024

Though maybe there might be a stable version of the docs or something, but seems like master is the only option so nothing to consider. Thanks!

@jakkdl jakkdl merged commit 9dcf733 into python-trio:master Mar 3, 2024
28 checks passed
@trio-bot
Copy link

trio-bot bot commented Mar 3, 2024

Hey @kachida, it looks like that was the first time we merged one of your PRs! Thanks so much! 🎉 🎂

If you want to keep contributing, we'd love to have you. So, I just sent you an invitation to join the python-trio organization on Github! If you accept, then here's what will happen:

  • Github will automatically subscribe you to notifications on all our repositories. (But you can unsubscribe again if you don't want the spam.)

  • You'll be able to help us manage issues (add labels, close them, etc.)

  • You'll be able to review and merge other people's pull requests

  • You'll get a [member] badge next to your name when participating in the Trio repos, and you'll have the option of adding your name to our member's page and putting our icon on your Github profile (details)

If you want to read more, here's the relevant section in our contributing guide.

Alternatively, you're free to decline or ignore the invitation. You'll still be able to contribute as much or as little as you like, and I won't hassle you about joining again. But if you ever change your mind, just let us know and we'll send another invitation. We'd love to have you, but more importantly we want you to do whatever's best for you.

If you have any questions, well... I am just a humble Python script, so I probably can't help. But please do post a comment here, or in our chat, or on our forum, whatever's easiest, and someone will help you out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Google Docstring Format" link goes to 404
3 participants