This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Merge from master (October 30th, 2019) #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It reuses a standard mechanism, is less verbose and avoids including code that is never executed.
Queue.get() accepts any non-negative number, so 0 works. It's also not arbitrary like 1 was, and the test suite now takes one less second to run!
It was introduced in urllib3/urllib3#875, but since urllib3/urllib3#1495 twine is no longer a dev requirement.
Instead, install it on demand like twine.
The idea is to make sure that we'll get the pytest version we want: the last that supports Python 2. Using a different version in Python 2 and Python 3 is possible, but is likely to lead to trouble in the future.
It turns out that without turning this one it's difficult to list exactly the tests that failed.
The default pytest tracebacks are really verbose: for each function in the stack they include the whole function until the exception, and the representation of its parameters. On the other hand, native tracebacks are way more concise, showing only two lines for each function and exception chains. The benefits of switching to native tracebacks: * The useful information fits in one screen * Python trains us to read those tracebacks from day one * We avoid the verbosity of showing the source code: we can already see it in GitHub and our editors * While we lose the information about parameters, I've never found this information to be useful I've been using this configuration for a few months now and never looked back!
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
…om-master-2019-10-30
Codecov Report
@@ Coverage Diff @@
## bleach-spike #136 +/- ##
=============================================
Coverage 99.25% 99.25%
=============================================
Files 29 29
Lines 2005 2005
=============================================
Hits 1990 1990
Misses 15 15
|
|
I will raise the PR for upstream |
|
Thank you for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tricky part here, as identified by @RatanShreshtha is the chunked commit. Here's my merge commit: 4de9315
I switched to use lower-case headers:
b"transfer-encoding: chunked", and sent a request with a body, in order to trigger chunked encoding. I use an iterable body so that it keeps working if/when we start supporting those. See #135 for details. My goal here wasn't to decide what we'll be doing in the future, but just get this merged.Everything else went quite smoothly. I just had to circumvent mhammond/pywin32#1439, fixed in f331ec4.