Type hints #1677
Merged
Type hints #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conengmo
force-pushed
the
type-hints-take2
branch
from
aeb5810
to
96fedd6
Compare
Conengmo
force-pushed
the
type-hints-take2
branch
from
0473f87
to
a1d11b9
Compare
ocefpaf
approved these changes
Dec 27, 2022
Conengmo
force-pushed
the
type-hints-take2
branch
from
a1d11b9
to
95e828f
Compare
|
Thanks for the review @ocefpaf! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try this again. Based on #1297. Closes #1559.
I didn't do the plugins, I'll leave that for another time.