Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy 2.0 support #1937

Closed
jakirkham opened this issue Apr 25, 2024 · 4 comments · Fixed by #1938
Closed

NumPy 2.0 support #1937

jakirkham opened this issue Apr 25, 2024 · 4 comments · Fixed by #1938

Comments

@jakirkham
Copy link

jakirkham commented Apr 25, 2024

Is your feature request related to a problem? Please describe.

NumPy 2.0 is coming out soon ( numpy/numpy#24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out 3 weeks back ( numpy/numpy#24300 (comment) ). It would be good to start running CI with NumPy 2.0 for folium and branca

Describe the solution you'd like

To prepare for NumPy 2.0, it might be worthwhile to start testing folium and branca against NumPy 2 in CI

Also a branca release (containing the NumPy 2 fixes), would help ensure users get a NumPy 2 compatible release

Lastly NumPy is tracking ecosystem support for NumPy 2.0, it would be helpful to share folium's and branca's current status in issue: numpy/numpy#26191

Describe alternatives you've considered

NA

Additional context

NA

Implementation

This likely involves some tweaks to CI (or maybe a new CI job)

@martinfleis
Copy link
Collaborator

martinfleis commented Apr 25, 2024

It would be good to confirm folium works with NumPy 2.0

It does now, I verified that locally when doing the fix in python-visualization/branca#163. We just need a new release of branca (@ocefpaf can you do that?). Folium itself should be compatible without changes.

I will add a CI env testing against nightly both here and in branca.

@jakirkham
Copy link
Author

Thanks Martin! 🙏

Have tried to revise the issue text. Please let me know whether that looks better. Happy to edit further

@ocefpaf
Copy link
Member

ocefpaf commented Apr 25, 2024

ocefpaf can you do that?). Folium itself should be compatible without changes.

Doing that now. I was wrong about np.histogram! I would never have guessed that the problem was floats objects instead 😄

@martinfleis
Copy link
Collaborator

I would never have guessed that the problem was floats objects instead

took me a while to figure that out :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants