Errors with python3.7

[RouquinBlanc]

Hi Aymeric,

I may be missing something, but it seems to me that the code is currently not yet compatible with python 3.7 (tested with top of master)

The best way to reproduce is the first test example of the doc:

import asyncio
import datetime
import random
import websockets

async def time(websocket, path):
    while True:
        now = datetime.datetime.utcnow().isoformat() + 'Z'
        await websocket.send(now)
        await asyncio.sleep(random.random() * 3)

start_server = websockets.serve(time, '127.0.0.1', 5678)
asyncio.get_event_loop().run_until_complete(start_server)
asyncio.get_event_loop().run_forever()

This raises this exception:

TypeError: cannot 'yield from' a coroutine object in a non-coroutine generator

I've seen you are doing some changes at the moment for python3.7, I will be happy to validate further changes. Did not catch it earlier because we were stuck with the pyyaml lib even earlier in our deployment... They are pushing deprecation very strongly!

[Harmon758]

I'm only able to reproduce this with 5.0.1 and not the top of master.
Make sure you're up to date?

[RouquinBlanc]

Indeed... Sorry I mixed up 2 virtualenvs.

So yes I see the same, not working on 5.0.1, but fine on master.

I guess a new patch release is planed for soon then?

Thanks a lot!

[Harmon758]

No problem.
I agree, there should be a new release for 3.7 support now that 3.7.0 has been released.

[adam-stokes]

Hi, any eta when a new release will be pushed?

[aaugustin]

Closing as a duplicate of #405.

@battlemidget No ETA on a release but I'll try to take a look at pending issues over the week-end.

[aaugustin]

Well, it was a nice sunny weekend, so no progress here.

[adam-stokes]

It's been over a week, any idea on when a new release will be published?

[aaugustin]

Almost certainly before September.

[aaugustin]

(I could type python setup.py sdist bdist_wheel; twine upload — I just typed it. But I also need to have enough time to follow up if the release causes regressions for some users, which is almost guaranteed, as I'm no longer using websockets myself.)

[aaugustin]

#435 suggests that master isn't compatible with Python 3.7 yet.

[aaugustin]

(which is a release blocker)

[aaugustin]

#437 is another release blocker.

[aaugustin]

Version 6.0 adds support for Python 3.7 and is now available on PyPI: https://pypi.org/project/websockets/6.0/#files