Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize dns objects by adding pxd files #1113

Merged
merged 8 commits into from Dec 18, 2022
Merged

feat: optimize dns objects by adding pxd files #1113

merged 8 commits into from Dec 18, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 18, 2022

This will help with the object construction and throw away when we suppress the response in the handlers.

@bdraco bdraco changed the title feat: add pxd files for dns objects feat: Optimize dns object by adding pxd files Dec 18, 2022
@bdraco bdraco changed the title feat: Optimize dns object by adding pxd files feat: Optimize dns objectsby adding pxd files Dec 18, 2022
@bdraco bdraco changed the title feat: Optimize dns objectsby adding pxd files feat: Optimize dns objects by adding pxd files Dec 18, 2022
@bdraco bdraco changed the title feat: Optimize dns objects by adding pxd files feat: optimize dns objects by adding pxd files Dec 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Base: 99.72% // Head: 99.72% // No change to project coverage 👍

Coverage data is based on head (33b5865) compared to base (11f3f0e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1113   +/-   ##
=======================================
  Coverage   99.72%   99.72%           
=======================================
  Files          22       22           
  Lines        2561     2561           
  Branches      452      452           
=======================================
  Hits         2554     2554           
  Misses          5        5           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review December 18, 2022 03:09
@bdraco bdraco merged commit 919d4d8 into master Dec 18, 2022
@bdraco bdraco deleted the dns_pxd branch December 18, 2022 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants