New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize the dns cache #1119
Conversation
Codecov ReportBase: 99.72% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1119 +/- ##
=======================================
Coverage 99.72% 99.72%
=======================================
Files 22 22
Lines 2567 2569 +2
Branches 454 452 -2
=======================================
+ Hits 2560 2562 +2
Misses 5 5
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -487,7 +483,7 @@ def __eq__(self, other: Any) -> bool: | |||
isinstance(other, DNSNsec) | |||
and self.next_name == other.next_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can move all the checks after the isinstance into a cdef with the other typed to the same type which will avoid all the python accessor overhead since we can access the struct values in C instead
Worked great overnight. #1119 (comment) can happen in another PR |
This adds a pxd file for
_cache.py
and cleans up the one for_dns.py
This also fixes some conflating of
DNSRecord
andDNSEntry