Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNSService and DNSPointer equality check should be case insensitive #1121

Closed
bdraco opened this issue Dec 21, 2022 · 1 comment · Fixed by #1122
Closed

DNSService and DNSPointer equality check should be case insensitive #1121

bdraco opened this issue Dec 21, 2022 · 1 comment · Fixed by #1122
Assignees
@bdraco

Comments

@bdraco
Copy link
Member

bdraco commented Dec 21, 2022

The equality check and hash should use server_key and not server

python-zeroconf/src/zeroconf/_dns.py

Line 414 in 255a884

self._hash = hash((self.key, type_, self.class_, priority, weight, port, server))

@bdraco bdraco mentioned this issue Dec 21, 2022
Merged
@bdraco
Copy link
Member Author

bdraco commented Dec 21, 2022

The DNSPointer check is probably wrong as well.

@bdraco bdraco changed the title DNSService equality check should be case insensitive DNSService and DNSPointer equality check should be case insensitive Dec 21, 2022
@bdraco bdraco self-assigned this Dec 22, 2022
@bdraco bdraco mentioned this issue Dec 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bdraco bdraco

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@bdraco