Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include tests and docs in sdist archives #1142

Merged
merged 1 commit into from Apr 2, 2023

Conversation

mgorny
Copy link

@mgorny mgorny commented Apr 1, 2023

Include documentation and test files in source distributions, in order to make them more useful for packagers (Linux distributions, Conda). Testing is an important part of packaging process, and at least Gentoo users have requested offline documentation for Python packages. Furthermore, the COPYING file was missing from sdist, even though it was referenced in README.

Include documentation and test files in source distributions, in order
to make them more useful for packagers (Linux distributions, Conda).
Testing is an important part of packaging process, and at least Gentoo
users have requested offline documentation for Python packages.
Furthermore, the COPYING file was missing from sdist, even though it was
referenced in README.
@bdraco bdraco changed the title feat: Include tests and docs in sdist archives feat: include tests and docs in sdist archives Apr 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (36d5b45) 99.76% compared to head (065adbe) 99.76%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1142   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          22       22           
  Lines        2605     2605           
  Branches      456      456           
=======================================
  Hits         2599     2599           
  Misses          4        4           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member

bdraco commented Apr 2, 2023

Thanks @mgorny

@bdraco bdraco merged commit da10a3b into python-zeroconf:master Apr 2, 2023
27 of 28 checks passed
@mgorny mgorny deleted the sdist branch April 2, 2023 14:54
@mgorny
Copy link
Author

mgorny commented Apr 2, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants