Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up incoming data parser #1161

Merged
merged 1 commit into from Apr 23, 2023
Merged

feat: speed up incoming data parser #1161

merged 1 commit into from Apr 23, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 23, 2023

This is roughly a 4.5% speed up against the incoming benchmark

This is roughly a 4.5% speed up against the incoming benchmark
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (70719dd) 99.81% compared to head (43b2cae) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2652     2657    +5     
  Branches      463      464    +1     
=======================================
+ Hits         2647     2652    +5     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/_dns.py 100.00% <100.00%> (ø)
src/zeroconf/_protocol/incoming.py 98.88% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented Apr 23, 2023

tested on a few production systems 👍

@bdraco bdraco merged commit cb4c3b2 into master Apr 23, 2023
30 checks passed
@bdraco bdraco deleted the parser_speed branch April 23, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant