Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up parsing NSEC records #1169

Merged
merged 1 commit into from May 3, 2023
Merged

feat: speed up parsing NSEC records #1169

merged 1 commit into from May 3, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 3, 2023

Benchmark before
Parsing 100000 incoming messages took 3.846316208015196 seconds

Benchmark after
Parsing 100000 incoming messages took 2.7343544159957673 seconds

Almost a 39% improvement

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fbaaf7b) 99.81% compared to head (5f8404e) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1169   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2667     2671    +4     
  Branches      464      464           
=======================================
+ Hits         2662     2666    +4     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_protocol/incoming.py 98.96% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review May 3, 2023 20:05
@bdraco bdraco merged commit 06fa94d into master May 3, 2023
30 checks passed
@bdraco bdraco deleted the nsec_records branch May 3, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant