Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve dns cache performance #1172

Merged
merged 1 commit into from May 25, 2023
Merged

feat: improve dns cache performance #1172

merged 1 commit into from May 25, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 9, 2023

No description provided.

src/zeroconf/_cache.pxd Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (963d022) 99.81% compared to head (4b9e3ed) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1172   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2673     2676    +3     
  Branches      465      466    +1     
=======================================
+ Hits         2668     2671    +3     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_cache.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented May 9, 2023

strange that making async_all_by_details a cpdef causes a seg fault

@bdraco bdraco marked this pull request as ready for review May 25, 2023 12:44
@bdraco bdraco merged commit bb496a1 into master May 25, 2023
30 checks passed
@bdraco bdraco deleted the cache_speed branch May 25, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant