feat: reduce overhead to enumerate ip addresses in ServiceInfo #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the reply overhead was because of the enums
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1181 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 22 22
Lines 2695 2700 +5
Branches 470 470
=======================================
+ Hits 2690 2695 +5
Misses 3 3
Partials 2 2
☔ View full report in Codecov by Sentry. |
bdraco
force-pushed
the
enum_overhead_py311
branch
from
a2fd7ad
to
13569fe
Compare
|
actions is busted |
|
This is nearly a 70% speed up to fetching the ips. That enum overhead is really suprising but we had the same issue with dbus-fast so it shouldn't be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the reply overhead was because of the enums which happens A LOT if there are homekit devices on the network