Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce overhead to handle queries and responses #1184

Merged
merged 2 commits into from Jun 17, 2023
Merged

feat: reduce overhead to handle queries and responses #1184

merged 2 commits into from Jun 17, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 15, 2023

  • adds slots to handler classes

  • avoid any expression overhead and inline instead

- adds slots to handler classes

- avoid any expression overhead and inline instead
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9ecce3a) 99.81% compared to head (02ea43e) 99.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1184   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files          22       22           
  Lines        2709     2717    +8     
  Branches      471      472    +1     
=======================================
+ Hits         2704     2712    +8     
  Misses          3        3           
  Partials        2        2           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_handlers.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco
Copy link
Member Author

bdraco commented Jun 17, 2023

List comps are going to get a lot faster in 3.12 via https://peps.python.org/pep-0709/ but any and all don’t seem to be included

@bdraco bdraco marked this pull request as ready for review June 17, 2023 18:44
@bdraco bdraco merged commit 81126b7 into master Jun 17, 2023
30 checks passed
@bdraco bdraco deleted the slots branch June 17, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant