Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reorder incoming data handler to reduce overhead #1189

Merged
merged 5 commits into from Jun 18, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 18, 2023

Unpacks the address only after we know we are going to process the incoming message

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: -0.04 ⚠️

Comparison is base (ac5c50a) 99.81% compared to head (0efa08d) 99.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1189      +/-   ##
==========================================
- Coverage   99.81%   99.77%   -0.04%     
==========================================
  Files          22       22              
  Lines        2719     2719              
  Branches      474      474              
==========================================
- Hits         2714     2713       -1     
  Misses          3        3              
- Partials        2        3       +1     
Impacted Files Coverage Δ
src/zeroconf/_core.py 99.77% <87.50%> (-0.23%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco marked this pull request as ready for review June 18, 2023 20:25
@bdraco bdraco merged commit 32756ff into master Jun 18, 2023
28 of 30 checks passed
@bdraco bdraco deleted the reorder_incoming_data branch June 18, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant