Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for sending to a specific addr and port with ServiceInfo.async_request and ServiceInfo.request #1192

Merged
merged 1 commit into from Jul 2, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jul 2, 2023

Passing addr and port is optional, and will default to the mDNS multicast address and port. This is useful for directing requests to a specific host that may be able to respond across subnets.

…o.async_request

Passing addr and port is optional, and will default to the
mDNS multicast address and port. This is useful for directing
requests to a specific host that may be able to respond across
subnets.
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8ae8ba1) 99.77% compared to head (8f5efad) 99.77%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1192   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          22       22           
  Lines        2721     2721           
  Branches      474      474           
=======================================
  Hits         2715     2715           
  Misses          3        3           
  Partials        3        3           
Impacted Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco changed the title feat: Add support for sending to a specific addr/port with ServiceInfo.async_request feat: add support for sending to a specific addr and port with ServiceInfo.async_request and ServiceInfo.request Jul 2, 2023
@bdraco bdraco marked this pull request as ready for review July 2, 2023 14:32
@bdraco bdraco merged commit 405f547 into master Jul 2, 2023
27 checks passed
@bdraco bdraco deleted the sending_to_addr branch July 2, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant