fix: revert DNSIncoming cimport in _dns.pxd #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1207 This seems to cause a problem for some systems. Its not clear why but this is likely the only change that could have triggered the issue so lets revert it
fixes #1207 This seems to cause a problem for some systems. Its not clear why but this is likely the only change that could have triggered the issue so lets revert it
Closed
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 22 22
Lines 2749 2749
Branches 477 477
=======================================
Hits 2743 2743
Misses 3 3
Partials 3 3
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1207
This seems to cause a problem for some systems. Its not clear why but this is likely the only change that could have triggered the issue so lets revert it