Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert adding typing to DNSRecord.suppressed_by #1210

Merged
merged 1 commit into from Aug 3, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 3, 2023

fixes #1207

This causes a cython compile crash

fixes #1207

This causes a cython compile crash
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.33% ⚠️

Comparison is base (5f14b6d) 99.78% compared to head (10f847f) 99.45%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   99.78%   99.45%   -0.33%     
==========================================
  Files          22       22              
  Lines        2749     2749              
  Branches      477      477              
==========================================
- Hits         2743     2734       -9     
- Misses          3        8       +5     
- Partials        3        7       +4     
Files Changed Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_dns.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 3dba5ae into master Aug 3, 2023
30 of 31 checks passed
@bdraco bdraco deleted the revert_typing branch August 3, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.72.0: build fails
1 participant