New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose flag to disable strict name checking in service registration #1215
feat: expose flag to disable strict name checking in service registration #1215
Conversation
👍 Thanks for this, hope it can be merged soon. For working with existing protocols that use strictly-invalid service types, we have had to adjust our monkeypatch several times. 🐒😄 |
@bdraco thanks for considering this PR when you have time |
This looks fine. It needs explicit test coverage for a few more places before merging. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1215 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 22 22
Lines 2757 2757
Branches 480 480
=======================================
Hits 2751 2751
Misses 3 3
Partials 3 3
☔ View full report in Codecov by Sentry. |
The following can be called directly so they should get a simple test to make sure disabling works when called directly:
These are exposed at the top level for backwards compat which we likely need to maintain forever so they should get a test as well:
|
to avoid BadTypeInNameException when registering non-standard services closes python-zeroconf#1046
by disabling 'strict' name checking
0d7771e
to
c8996e6
Compare
Hi @bdraco, please take a look now 👍 I was not sure where to put those calls:
Also, I re-pushed the branch to rename the old 2 commits (just de-capitalized the titles, after seeing a CI fail with the GAs 😅) |
Tested on production. Didn't find any issues Thanks @azogue |
closes #1046