Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor notify implementation to reduce overhead of adding and removing listeners #1224

Merged
merged 4 commits into from Aug 14, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 14, 2023

Noticed this while profiling the esphome code as it adds/remove listeners every time its trying to connect to an offline device

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (13d9aa5) 99.82% compared to head (5568b1a) 99.78%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   99.82%   99.78%   -0.04%     
==========================================
  Files          25       25              
  Lines        2789     2794       +5     
  Branches      480      480              
==========================================
+ Hits         2784     2788       +4     
  Misses          3        3              
- Partials        2        3       +1     
Files Changed Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_core.py 100.00% <100.00%> (ø)
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)
src/zeroconf/_utils/asyncio.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 14, 2023 19:49
@bdraco bdraco merged commit ceb92cf into master Aug 14, 2023
30 of 31 checks passed
@bdraco bdraco deleted the refactor_notify branch August 14, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant