Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize unpacking properties in ServiceInfo #1225

Merged
merged 1 commit into from Aug 15, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 15, 2023

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.32% 🎉

Comparison is base (ceb92cf) 99.49% compared to head (9000c69) 99.82%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1225      +/-   ##
==========================================
+ Coverage   99.49%   99.82%   +0.32%     
==========================================
  Files          25       25              
  Lines        2794     2790       -4     
  Branches      480      479       -1     
==========================================
+ Hits         2780     2785       +5     
+ Misses          8        3       -5     
+ Partials        6        2       -4     
Files Changed Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 15, 2023 20:07
@bdraco bdraco merged commit 1492e41 into master Aug 15, 2023
34 checks passed
@bdraco bdraco deleted the unpack_properties branch August 15, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant