feat: optimize processing of records in RecordUpdateListener subclasses #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
- Coverage 99.82% 99.78% -0.04%
==========================================
Files 25 25
Lines 2795 2790 -5
Branches 480 479 -1
==========================================
- Hits 2790 2784 -6
Misses 3 3
- Partials 2 3 +1
☔ View full report in Codecov by Sentry. |
bdraco
changed the title
bdraco
force-pushed
the
collapse_service_browser_branching
branch
2 times, most recently
from
85d6c2b
to
775b1da
Compare
These classes used to process a single record at a time, but since we now process them all in batches, we can remove all the breakout functions
bdraco
force-pushed
the
collapse_service_browser_branching
branch
from
775b1da
to
dbda037
Compare
11 tasks
bdraco
added a commit
to bdraco/esphome
that referenced
this pull request
Aug 22, 2023
The first step of removing the legacy update_record is in python-zeroconf/python-zeroconf#1231 This prepares esphome for this as its been deprecated for a few years and this one was missed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes used to process a single record at a time, but since we now process them all in batches, we can remove all the breakout functions. This will also fix futures not resolving since the legacy backcompat was partially broken in info.py
This removes the legacy
update_recordas its been a few years now frominfo.py(it was never called anyways except in tests), but leaves the one in_updates.pyfor back-compat as it appears some libs are not updated yetpython-zeroconf/src/zeroconf/_updates.py
Line 43 in b492eb4
python-zeroconf/src/zeroconf/_services/info.py
Line 413 in b492eb4