Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use server_key when processing DNSService records #1238

Merged
merged 2 commits into from Aug 28, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Aug 28, 2023

This is a small cleanup to avoid calling .lower() when we already have the server_key. performance benefit is negligible

This is a small cleanup to avoid calling .lower() when we already
have the server_key. performance benefit is negligible
This is a small cleanup to avoid calling .lower() when we already
have the server_key. performance benefit is negligible
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (68d9998) 99.82% compared to head (7879823) 99.78%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
- Coverage   99.82%   99.78%   -0.04%     
==========================================
  Files          25       25              
  Lines        2805     2805              
  Branches      479      479              
==========================================
- Hits         2800     2799       -1     
  Misses          3        3              
- Partials        2        3       +1     
Files Changed Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_core.py 100.00% <100.00%> (ø)
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review August 28, 2023 02:13
@bdraco bdraco merged commit cc8feb1 into master Aug 28, 2023
33 of 34 checks passed
@bdraco bdraco deleted the server_key_cleanup branch August 28, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant