fix: remove useless calls in ServiceInfo #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
bdraco
changed the title
bdraco
force-pushed
the
info_load_from_cache
branch
from
c336a49
to
516812e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_set_ipv4_addresses_from_cacheand_set_ipv6_addresses_from_cachewere useless calls because they would always load the same data that was being fed into the function fromload_from_cacheor nothing if there was nothing in the cache. Removing them has the same result because the data was being loaded twice when there was data in the cache.