Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reduce overhead to answer questions #1250

Merged
merged 3 commits into from Sep 2, 2023
Merged

feat: reduce overhead to answer questions #1250

merged 3 commits into from Sep 2, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 2, 2023 •
edited

  • only build known_answers_set once per question set
  • remove unused variables and code paths
  • unpack functions only called in one place

@bdraco
feat: reduce overhead to answer questions
816bc76 
- only build known_answers_set once per question set
- remove unused variables and code paths
@codecov
Copy link

codecov bot commented Sep 2, 2023 •
edited

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/zeroconf/__init__.py 100.00%
src/zeroconf/_handlers/query_handler.py 100.00%

📢 Thoughts on this report? Let us know!.

@bdraco
feat: reduce overhead to answer questions
7a6f880 
- only build known_answers_set once per question set
- remove unused variables and code paths
@bdraco
feat: reduce answer overhead
aa945d6
@bdraco bdraco marked this pull request as ready for review September 2, 2023 22:19
@bdraco bdraco merged commit 7cb8da0 into master Sep 2, 2023
33 of 34 checks passed
@bdraco bdraco deleted the handlers_cleanup branch September 2, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bdraco