Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up incoming packet processing with a memory view #1290

Merged
merged 4 commits into from Nov 5, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2023

All the single char conversions can avoid the bytes copy, and since there are a lot of them this is ~ an 8% speed up

All the single char conversions can avoid the bytes copy,
and since there are a lot of them this is ~ an 8% speed up
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/zeroconf/_protocol/incoming.py 99.01% <100.00%> (+<0.01%) ⬆️
src/zeroconf/_services/browser.py 99.22% <ø> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@bdraco bdraco marked this pull request as ready for review November 5, 2023 00:32
@bdraco bdraco merged commit f1f0a25 into master Nov 5, 2023
34 checks passed
@bdraco bdraco deleted the incoming_speed_up branch November 5, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant