Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up record updates #1301

Merged
merged 5 commits into from Nov 8, 2023
Merged

feat: speed up record updates #1301

merged 5 commits into from Nov 8, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 8, 2023

  • adds more cython types
  • convert RecordUpdate to a base class since NamedTuple has the unfortunate side effect of running a lambda on creation which can't be optimized away

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/zeroconf/__init__.py 100.00% <100.00%> (ø)
src/zeroconf/_handlers/query_handler.py 100.00% <100.00%> (ø)
src/zeroconf/_record_update.py 100.00% <100.00%> (ø)
src/zeroconf/_services/browser.py 99.23% <100.00%> (+<0.01%) ⬆️
src/zeroconf/_services/info.py 100.00% <100.00%> (ø)
src/zeroconf/_updates.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@bdraco bdraco marked this pull request as ready for review November 8, 2023 14:30
@bdraco bdraco merged commit d2af6a0 into master Nov 8, 2023
33 of 34 checks passed
@bdraco bdraco deleted the record_update branch November 8, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant