Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: performance regression with ServiceInfo IPv6Addresses #1330

Merged
merged 12 commits into from Dec 13, 2023
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 13, 2023

#1322 introduced a performance regression with IPv6 addresses

fixes #1329

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39c4005) 99.77% compared to head (62008c7) 99.77%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1330   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          29       30    +1     
  Lines        3106     3143   +37     
  Branches      522      524    +2     
=======================================
+ Hits         3099     3136   +37     
  Misses          5        5           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Dec 13, 2023

while we are at it, we should cache is_link_local

Screenshot 2023-12-13 at 10 50 58 AM

@bdraco
Copy link
Member Author

bdraco commented Dec 13, 2023

Verified this solves it.

Need to add more coverage

@bdraco bdraco marked this pull request as ready for review December 13, 2023 21:07
@bdraco bdraco merged commit e2f9f81 into master Dec 13, 2023
31 checks passed
@bdraco bdraco deleted the ipaddress_str branch December 13, 2023 21:07
@bdraco
Copy link
Member Author

bdraco commented Dec 13, 2023

I should have cached is_unspecified as well as we have 1000s of calls to that 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing scope id in serviceinfo results in a significant performance reduction
1 participant