Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: small performance improvement for ServiceInfo asking questions #1341

Merged
merged 1 commit into from Dec 15, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 15, 2023

No description provided.

@bdraco bdraco changed the title feat: small speed up for ServiceInfo asking questions feat: small performance improvement for ServiceInfo asking questions Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b595a1) 99.77% compared to head (ab3a1ec) 99.71%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1341      +/-   ##
==========================================
- Coverage   99.77%   99.71%   -0.07%     
==========================================
  Files          30       30              
  Lines        3164     3164              
  Branches      528      526       -2     
==========================================
- Hits         3157     3155       -2     
- Misses          5        7       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review December 15, 2023 18:36
@bdraco bdraco merged commit 810a309 into master Dec 15, 2023
29 of 31 checks passed
@bdraco bdraco deleted the info_speed_ups branch December 15, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant