feat: make async_get_service_info available on the Zeroconf object #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1366 +/- ##
==========================================
- Coverage 99.75% 99.75% -0.01%
==========================================
Files 30 30
Lines 3238 3237 -1
Branches 536 536
==========================================
- Hits 3230 3229 -1
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Since the AsyncServiceBrowser will return a Zeroconf object, it was not obvious how to do an async lookup because only get_service_info was exposed on the Zeroconf object. async_get_service_info has been moved to the Zeroconf object, and AsyncZeroconf.async_get_service_info now wraps this method related issue #1286
Since the AsyncServiceBrowser will return a Zeroconf object, it was not obvious how to do an async lookup because only get_service_info was exposed on the Zeroconf object. async_get_service_info has been moved to the Zeroconf object, and AsyncZeroconf.async_get_service_info now wraps this method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the AsyncServiceBrowser will return a Zeroconf object, it was not obvious how to do an async lookup because only get_service_info was exposed on the Zeroconf object. async_get_service_info has been moved to the Zeroconf object, and AsyncZeroconf.async_get_service_info now wraps this method
related issue #1286