Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid including scope_id in IPv6Address object if its zero #1367

Merged
merged 2 commits into from Apr 1, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 1, 2024

If the scope_id is 0 it should not be included in the IPv6Address object

fixes #1361

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.75%. Comparing base (517d7d0) to head (99aa376).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1367      +/-   ##
==========================================
- Coverage   99.75%   99.75%   -0.01%     
==========================================
  Files          30       30              
  Lines        3238     3235       -3     
  Branches      536      536              
==========================================
- Hits         3230     3227       -3     
  Misses          5        5              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit edc4a55 into master Apr 1, 2024
31 checks passed
@bdraco bdraco deleted the fix_zero_scope_id branch April 1, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parsed_scoped_addresses() may return link-local IPv6 addresses with %0 as the scope id.
1 participant