Skip to content
This repository has been archived by the owner on Nov 23, 2017. It is now read-only.

Reduce reliance on get_event_loop() #50

Closed
GoogleCodeExporter opened this issue Apr 10, 2015 · 3 comments
Closed

Reduce reliance on get_event_loop() #50

GoogleCodeExporter opened this issue Apr 10, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

See this thread:
https://groups.google.com/forum/#!topic/python-tulip/hr1kPZfMX8U

Even if we don't remove get_event_loop() and set_event_loop(), the tulip code 
itself should not need to call it whenever an event loop is already available.  
For example, any code calling Future() from inside some code that has a loop 
parameter or instance variable should be modified to pass that loop on to the 
Future constructor instead of letting the latter call get_event_loop().

Also, calling set_event_loop(None) explicitly should not cause a subsequent 
call to get_event_loop() to create a new event loop instance.

I have work in progress for this:
https://codereview.appspot.com/12637044/

Original issue reported on code.google.com by gvanrossum@gmail.com on 8 Aug 2013 at 10:40

@GoogleCodeExporter
Copy link
Author

That's checked in. Keeping this open until:

- the http tests are also fixed

- I've updated the PEP with the new specs for get_event_loop()

Original comment by gvanrossum@gmail.com on 9 Aug 2013 at 6:36

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Is it still active?

Original comment by andrew.s...@gmail.com on 21 Aug 2013 at 2:01

@GoogleCodeExporter
Copy link
Author

All tests have been changed to use set_event_loop(None).

Original comment by gvanrossum@gmail.com on 21 Aug 2013 at 2:27

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant