Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Description of LOAD_CLOSURE in dis module should be updated #102636

Closed
c2170 opened this issue Mar 13, 2023 · 2 comments
Closed

Docs: Description of LOAD_CLOSURE in dis module should be updated #102636

c2170 opened this issue Mar 13, 2023 · 2 comments
Labels
docs Documentation in the Doc dir stdlib Python modules in the Lib dir

Comments

@c2170
Copy link

c2170 commented Mar 13, 2023

Documentation

In the description of LOAD_CLOSURE, I think there is no longer exists co_fastlocalnames attribute. It may need to be updated.

https://docs.python.org/3/library/dis.html
@c2170 c2170 added the docs Documentation in the Doc dir label Mar 13, 2023
@hugovk
Copy link
Member

hugovk commented Mar 13, 2023

Looks like this was added in PR #26388, but I also see a revert and unrevert in its issue, #87859...

Let's ask @ericsnowcurrently: should this reference to co_fastlocalnames be removed from the docs?

@hugovk hugovk added the stdlib Python modules in the Lib dir label Mar 13, 2023
@polynomialherder
Copy link
Contributor

I think this was corrected in PR #106059 @hugovk @c2170

@hugovk hugovk closed this as completed Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @polynomialherder @c2170