Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler's line number propagation algorithm could be more robust #103795

Open
iritkatriel opened this issue Apr 24, 2023 · 0 comments
Open

compiler's line number propagation algorithm could be more robust #103795

iritkatriel opened this issue Apr 24, 2023 · 0 comments
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

The bug in #101517 was due to a raise instruction not being assigned a line number. This happened because the compiler's line number propagation algorithm cannot propagate line numbers to blocks that have two predecessors. The fix for that case was to reorganise the instructions so that this situation is avoided.

We should

  1. Be able to detect when this happens (via assertions in the compiler).
  2. Make the line number propagation algorithm more robust so that this doesn't happen.

See also #103550 (review).

CC @carljm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Development

No branches or pull requests

1 participant