Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Emscripten from the docs #115977

Closed
brettcannon opened this issue Feb 26, 2024 · 11 comments · Fixed by #117057
Closed

Remove Emscripten from the docs #115977

brettcannon opened this issue Feb 26, 2024 · 11 comments · Fixed by #117057
Labels
3.13 new features, bugs and security fixes docs Documentation in the Doc dir easy OS-wasi

Comments

@brettcannon
Copy link
Member

Since Emscripten is no longer a tier 3 platform we should probably remove mentions of it from the docs.

@brettcannon brettcannon added docs Documentation in the Doc dir OS-wasi 3.13 new features, bugs and security fixes labels Feb 26, 2024
@hugovk hugovk added the easy label Feb 27, 2024
@tavallaie
Copy link

how we can help this issue? I need to know more to solve it.

@brettcannon
Copy link
Member Author

Basically the docs say things like "Emscripten" or "not Emscripten" about platform support. Pretty much all mentions of "Emscripten" in the documentation should probably be removed.

@tavallaie
Copy link

Thansk, I will remove all of them, if there is any docs or related information about removing Emscripten like "why Emscripten is no longer a tier 3 platform "can mention in my PR please help me to find them.

@brettcannon
Copy link
Member Author

Thansk, I will remove all of them, if there is any docs or related information about removing Emscripten like "why Emscripten is no longer a tier 3 platform "can mention in my PR please help me to find them.

You don't need an official link; the core team knows the "why".

@ned-deily
Copy link
Member

It looks like there are still some Emscripten references in the docs beyond the ones removed by #117057.

@freakboy3742
Copy link
Contributor

@ned-deily Which references in particular are you referring to?

As noted in this comment, some of the Emscripten references were left in deliberately, reflecting the fact that the functionality exists, even if the platform isn't tier 3. This is analogous to the state of Android in previous releases - there are a handful of references to Android in the docs, even though Android isn't Tier 3 in those releases.

I'm happy to do the cleanup on this if needed; I just need to be clear about what I'm cleaning up :-)

@nineteendo
Copy link
Contributor

"Emscripten" is found in library/intro.rst, library/sys.rst & the release notes like mentioned in your comment. But also in using/configure.rst. If that's deliberate, then this issue should be closed, otherwise they should be removed from the latter.

@freakboy3742
Copy link
Contributor

My read is that the mentions in using/configure.rst is in the same category as the ones in library - it's describing how to configure a build for Emscripten. That is still a valid configuration, just not a Tier 3 supported configuration.

@nineteendo
Copy link
Contributor

OK, then I think you can close this.

@freakboy3742
Copy link
Contributor

@ned-deily Did you have any specific concerns, or are you OK with closing this?

@ned-deily
Copy link
Member

Sounds good, I think we can close this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 new features, bugs and security fixes docs Documentation in the Doc dir easy OS-wasi
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants